plugins/tracing/js/index.ts (1)

1-1: If bindings.gen has a default export, re-export it too.
Prevents breaking consumers expecting a default.

 export * from "./bindings.gen";
+export { default } from "./bindings.gen";

plugins/tracing/tsconfig.json (1)

3-3: Widen include to future subfolders.
Covers nested files without future tsconfig churn.

-  "include": ["./js/*.ts"],
+  "include": ["./js/**/*.ts"],

plugins/tracing/.gitignore (1)

7-9: Add pnpm lockfile ignore (if repo uses pnpm).
Keeps lockfile noise out of the plugin package.

 debug.log
 package-lock.json
 .vscode/settings.json
 yarn.lock
+pnpm-lock.yaml

plugins/tray/src/ext.rs (1)

139-144: Improve About dialog readability with sub-bullets for backends.
Keeps list visually aligned with the other bullets.

-                        let backends_formatted = app_backends
-                            .iter()
-                            .map(|b| format!("{:?}", b))
-                            .collect::<Vec<_>>()
-                            .join("\n");
+                        let backends_formatted = app_backends
+                            .iter()
+                            .map(|b| format!("  • {:?}", b))
+                            .collect::<Vec<_>>()
+                            .join("\n");
 
-                        let message = format!(
-                            "• App Name: {}\n• App Version: {}\n• SHA:\n  {}\n• Backends:\n{}",
-                            app_name, app_version, app_commit, backends_formatted
-                        );
+                        let message = format!(
+                            "• App Name: {}\n• App Version: {}\n• SHA:\n  {}\n• Backends:\n{}",
+                            app_name, app_version, app_commit, backends_formatted
+                        );

Also applies to: 146-148

plugins/tracing/src/errors.rs (2)

3-4: Empty error type makes Result<_, Error> uninhabited — is this intentional?

With pub enum Error {} you can’t construct an error; any Result<T, Error> can never be Err. If that’s the goal, consider using core::convert::Infallible for clarity; otherwise add variants later.

---

6-13: Avoid String allocation in Serialize impl

Use the serializer’s collect_str to format via Display without allocating.

 impl Serialize for Error {
     fn serialize<S>(&self, serializer: S) -> std::result::Result<S::Ok, S::Error>
     where
         S: Serializer,
     {
-        serializer.serialize_str(self.to_string().as_ref())
+        serializer.collect_str(self)
     }
 }

plugins/tracing/package.json (1)

1-11: Add a prepare script to generate bindings
In plugins/tracing/package.json, under “scripts” add:

"prepare": "npm run codegen"

This guarantees that bindings.gen.ts (currently missing from plugins/tracing/js) is generated before install/build, preventing import errors in index.ts.

plugins/tracing/src/commands.rs (2)

1-7: Use the crate’s error type instead of String for consistency

You already define crate::Error. Returning it improves typing across Rust/TS via specta.

-use crate::TracingPluginExt;
+use crate::TracingPluginExt;

 #[tauri::command]
 #[specta::specta]
-pub async fn hi<R: tauri::Runtime>(app: tauri::AppHandle<R>) -> Result<(), String> {
-    app.hi().map_err(|e| e.to_string())
+pub async fn hi<R: tauri::Runtime>(app: tauri::AppHandle<R>) -> Result<(), crate::Error> {
+    app.hi()
 }

---

1-7: Remove unused hi command and trait
No call sites for hi exist; drop the pub async fn hi in plugins/tracing/src/commands.rs and the corresponding hi method in plugins/tracing/src/ext.rs to eliminate dead API.

plugins/tracing/src/ext.rs (1)

1-9: Placeholder extension method—either implement a real action or remove

hi() returns Ok(()) and does nothing. Either implement a meaningful operation (e.g., rotate logs, return log file path) or remove to reduce surface area.

-pub trait TracingPluginExt<R: tauri::Runtime> {
-    fn hi(&self) -> Result<(), crate::Error>;
-}
-
-impl<R: tauri::Runtime, T: tauri::Manager<R>> TracingPluginExt<R> for T {
-    fn hi(&self) -> Result<(), crate::Error> {
-        Ok(())
-    }
-}
+pub trait TracingPluginExt<R: tauri::Runtime> {}
+impl<R: tauri::Runtime, T: tauri::Manager<R>> TracingPluginExt<R> for T {}

plugins/tracing/Cargo.toml (3)

1-9: Package metadata is minimal; keep or expand intentionally

If this is internal-only, fine. If publishing later, add license, repository, and a short description.

---

16-21: Drop unnecessary tauri features to reduce compile time/binary size

The tracing plugin likely doesn’t need tray-icon or image-png.

-tauri = { workspace = true, features = ["tray-icon", "image-png"] }
+tauri = { workspace = true }

---

28-30: Remove unused serde_json dependency
No references to serde_json were found in plugins/tracing/src; safely remove the line in Cargo.toml. Other deps (dirs, tracing-appender, tracing-subscriber) are confirmed in use.

plugins/tracing/src/lib.rs (2)

8-15: Prefer the public prelude import for readability.

Avoid the internal path __tracing_subscriber_SubscriberExt.

Apply:

-use tracing_subscriber::{
-    fmt, prelude::__tracing_subscriber_SubscriberExt, util::SubscriberInitExt, EnvFilter,
-};
+use tracing_subscriber::{fmt, prelude::*, util::SubscriberInitExt, EnvFilter};

---

61-82: Use Tauri’s path resolver instead of dirs::data_dir to follow platform conventions and config changes.

Resolves the base directory from the app, not global OS dirs + bundle id.

Apply:

-fn make_file_writer_if_enabled(
-    enabled: bool,
-    bundle_identifier: &str,
-) -> Option<(tracing_appender::non_blocking::NonBlocking, WorkerGuard)> {
+fn make_file_writer_if_enabled(
+    enabled: bool,
+    app: &tauri::AppHandle<tauri::Wry>,
+) -> Option<(tracing_appender::non_blocking::NonBlocking, WorkerGuard)> {
@@
-    let base_dir: PathBuf = match dirs::data_dir() {
-        Some(p) => p,
-        None => return None,
-    };
-
-    let logs_dir = base_dir.join(bundle_identifier).join("logs");
+    let base_dir: PathBuf = match app.path().app_data_dir() {
+        Some(p) => p,
+        None => return None,
+    };
+    let logs_dir = base_dir.join("logs");

And at call site:

-            if let Some((file_writer, guard)) = make_file_writer_if_enabled(true, &bundle_id) {
+            if let Some((file_writer, guard)) = make_file_writer_if_enabled(true, app) {

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

crates/detect/src/list.rs (1)

47-73: Good: helper gated with the same target; consider consolidating cfg to reduce repetition

The private helper is correctly macOS-only. If this pattern spreads, consider a small module to centralize gating and re-export the public API.

Example outline (illustrative, no behavior change):

+#[cfg(target_os = "macos")]
+mod macos_impl {
+    use super::*;
+    // existing macOS implementations here
+}
+#[cfg(target_os = "macos")]
+pub use macos_impl::list_installed_apps;

crates/whisper-local/src/model.rs (1)

173-176: Use character count instead of byte length for "text_length".

len() on a UTF-8 String counts bytes, not user-perceived characters. If you intended characters, switch to .chars().count().

-            tracing::info!(text_length = full_text.len(), "transcribe_completed");
+            tracing::info!(text_length = full_text.chars().count(), "transcribe_completed");

plugins/tracing/src/commands.rs (1)

5-10: Avoid unnecessary clone and async.

This command is sync and doesn’t await; also you can borrow the identifier to skip the clone.

-#[tauri::command]
-#[specta::specta]
-pub async fn logs_dir<R: tauri::Runtime>(app: tauri::AppHandle<R>) -> Result<PathBuf, String> {
-    let bundle_id = app.config().identifier.clone();
-    app.logs_dir(bundle_id).map_err(|e| e.to_string())
-}
+#[tauri::command]
+#[specta::specta]
+pub fn logs_dir<R: tauri::Runtime>(app: tauri::AppHandle<R>) -> Result<PathBuf, String> {
+    let bundle_id = &app.config().identifier;
+    app.logs_dir(bundle_id).map_err(|e| e.to_string())
+}

plugins/tracing/src/ext.rs (1)

8-12: Document why unwrap is acceptable here.

Add a brief “why” comment to justify unwrap() in supported environments.

 impl<R: tauri::Runtime, T: tauri::Manager<R>> TracingPluginExt<R> for T {
     fn logs_dir(&self, bundle_id: impl Into<String>) -> Result<PathBuf, crate::Error> {
-        let base_dir = dirs::data_dir().unwrap();
+        // SAFETY: In supported targets for the app, a data_dir is guaranteed by the OS;
+        // unwrap keeps this helper simple and avoids plumbing errors for a non-critical path.
+        let base_dir = dirs::data_dir().unwrap();
         let logs_dir = base_dir.join(bundle_id.into()).join("logs");
         let _ = std::fs::create_dir_all(&logs_dir);
         Ok(logs_dir)
     }
 }

apps/desktop/src/components/settings/views/help-feedback.tsx (2)

20-24: Tiny cleanup: inline the then callback.

Same behavior, less noise.

-  const handleOpenLogs = () => {
-    tracingCommands.logsDir().then((logsDir) => {
-      openPath(logsDir);
-    });
-  };
+  const handleOpenLogs = () => {
+    tracingCommands.logsDir().then(openPath);
+  };

---

91-109: Use a distinct icon for Logs to avoid confusion with “Report a Bug”.

Both entries use Bug; switch Logs to a document-style icon.

Apply within this block:

-              <Bug className="h-5 w-5 text-gray-600" />
+              <FileText className="h-5 w-5 text-gray-600" />

Additionally (outside this range), update imports at the top:

import { Book, Bug, ExternalLinkIcon, MessageSquare, FileText } from "lucide-react";

Optional: these buttons share identical structure; consider extracting a small <SettingsLinkButton …> to reduce duplication.

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.